Re: [nmap-svn] r36090 - nmap-exp/tudor/nsock-iocp/nsock/src

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [nmap-svn] r36090 - nmap-exp/tudor/nsock-iocp/nsock/src

Henri Doreau
2016-08-09 12:56 GMT+02:00  <[hidden email]>:

> Author: tudor
> Date: Tue Aug  9 03:56:31 2016
> New Revision: 36090
>
> Log:
> added a macro for the size of the read buffer
>
> Modified:
>    nmap-exp/tudor/nsock-iocp/nsock/src/nsock_core.c
>    nmap-exp/tudor/nsock-iocp/nsock/src/nsock_engines.c
>    nmap-exp/tudor/nsock-iocp/nsock/src/nsock_internal.h
>    nmap-exp/tudor/nsock-iocp/nsock/src/nsock_iocp.c
> [...]

Hi there,

make sure you do one thing per commit. Although the message here seems
to indicate a precise change, the patch also changes the priority of
the engine in the list. This is a good thing to do but it should be
done separately and documented in the commit message.

(I am still reviewing this code btw and would have a few things to
clarify, please don't merge it yet)

Regards

Henri
_______________________________________________
Sent through the dev mailing list
https://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/